Fix for scrolling in POC chat window when LLM response is inbound#4
Open
secretrobotron wants to merge 1 commit into
Open
Fix for scrolling in POC chat window when LLM response is inbound#4secretrobotron wants to merge 1 commit into
secretrobotron wants to merge 1 commit into
Conversation
…se is inbound Added structure for gating scrollToBottom on whether or not user is already at bottom of chat window, or jumps there explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In chat POC, added gating on scrollToBottom to prevent scrolling to bottom on whether or not user is already at bottom of chat window, or jumps there explicitly. Without a fix like this, reading what the LLM has produced requires waiting until it's done responding, since any vertical update will try to also update scroll to bottom.
Testing
Checklist
cargo test,npm test)cargo fmt)